search

unikent / programmes-plant

A comprehensive solution for the management of university programmes, that produces an XCRI feed.
Other
7 stars 4 forks source link

Fix/stop removing old uploads #990

Closed cfc7-unikent closed 4 years ago

cfc7-unikent commented 4 years ago

fix is https://github.com/unikent/programmes-plant/commit/d2a87a7356bfe1c4d87c8c6e5221a8c52d8fdd0d other commits after are various kentstandards based formatting fixes

This fix changes the processing of file fields so that the processing of the filename only occurs when we have a sucessfully file upload. Otherwise the processing was replacing any existing uploaded file paths with an empty string. This leads to the bug where creating a new revision of a programme removes any uploaded files. See https://trello.com/c/Os5qlBeA/249-programmes-plant-programme-specifications-upload-error

cfc7-unikent commented 4 years ago

I have no idea why github is adding all those commits too.