search

unisonweb / ui-core

Shared design system and core components for Unison Local and Unison Share
MIT License
23 stars 4 forks source link

Minimap breaks layout when it gets too long #81

Closed andreystepanov closed 8 months ago

andreystepanov commented 10 months ago

When minimap gets too long (while exploring big libraries like base) it creates some weird empty spots in UI.

To fix this, we might limit workspace-minimap height to available viewport height (max-height: 80vh looks ok, see screenshot).

Current

shot-2024-01-28-at-14-03-06--area

With max-height: 80vh; overflow: auto; fix

shot-2024-01-28-at-14-11-16--area

hojberg commented 10 months ago

Hmmmm this might be ok for now, but the magic of 80vh might bite us in the foot later. Seems like something we'd forget to adjust if the header ever changes height. 🤔

jcwilk commented 9 months ago

+1, I'm constantly battling the empty space on the bottom of the screen from this :sweat_smile: maybe I'll add a css adjustment extension to hold me over with andrey's suggestion

jcwilk commented 9 months ago

FWIW I had better luck limiting the height of workspace-minimap_entries so the "close all" headers etc don't get scrolled, eye of the beholder maybe

Screenshot_2024-02-06_14-27-58

hojberg commented 8 months ago

This was fixed by #84