unisonweb / ui-core

Shared design system and core components for Unison Local and Unison Share
MIT License
23 stars 4 forks source link

Consider adding `close` action for each minimap item #85

Closed andreystepanov closed 8 months ago

andreystepanov commented 8 months ago

While exploring codebase, i can't close top-most opened definition, because controls are hidden behind minimap menu.

Granted, it happens only if some other definition requires more space, which makes all opened definitions the same width.

Example with opened minimap

shot-2024-03-28-at-13-05-53--area

Example with collapsed minimap

Logical next step is to collapse minimap, but it doesn't help. You still need to "hunt" for that close button (only small part of it is visible).

shot-2024-03-28-at-13-06-28--area

Possible solution

The solution to all of these edge-cases might be as simple as adding close action to each item in minimap, in addition to close buttons inside definition blocks itself.

For inactive items (not currently selected definition) close action might be visible only on hover, if needed (to keep it clean).

shot-2024-03-28-at-13-25-28--area

hojberg commented 8 months ago

Having an x on the minimap items sounds great, but we need to fix the bigger issues of weirdly wide open definitions

hojberg commented 8 months ago

Just added this 🎉

andreystepanov commented 8 months ago

Looking gooood :)

Thanks, Simon!