Closed Misty-W closed 1 year ago
Good point! Do you have name suggestions? E.g.
in_out_converter()
?
make_multi_frontend()
?
This issue had no activity for 4 months, and will be closed in 2 weeks unless there is new activity. Cheers!
Hey Misty! I would love to give this a whirl!
@MZuhairKhan, it's yours! Just to double check, did you register at https://unitaryhack.dev/ ?
@andreamari Yes, I have registered this account!
@MZuhairKhan, anything we can help with?
3. ensuring tests cover more than just noise scaling functions.
@Misty-W, Yes, what other tests do I need to add? Will these be unit tests or something else?
what other tests do I need to add? Will these be unit tests or something else?
That's a good question, sorry it wasn't a little more clear! I think it depends on how you write the docstring and rename the function. If you put up a PR we'd be happy to provide some feedback directly on code!
@natestemen Sorry for the later reply. I have just renamed the built-in test for now. You can have a look at the PR above. I'll make any changes asap, specially if you dislike the name.
The
noise_scaling_converter
function needs to be renamed to reflect its generality. It can be applied in many more cases than just noise-scaling functions.Resolution of this issue will require