Update JUnit version

[furlaneto]

Hey guys, I saw that the API are not using the last version of JUnit and as improvement process, I would update the JUnit library. I can start with the API and after the others projects like indriya

[keilw]

Sure, you worked on JNoSQL it seems, so I assume you signed the ECA or are Eclipse committer already? What about JCP membership? Both the JSR 385 API and RI Indriya require those who contribute to either be full or Associate JCP members. You don't seem to be right now (https://jcp.org/en/participation/members/F), but @otaviojava can certainly help you. And if some of JNoSQL migrates into a JCP standard some day, that could also help with that ;-)

[furlaneto]

Yeah, I signed the ECA. Ok! I gonna see about JCP membership. Thanks @keilw

Great, any progress about the JCP membership? I just resolved https://github.com/unitsofmeasurement/indriya/issues/24 for the RI, what's necessary e.g. in the POM could be inspired by that. There are much fewer JUnit tests in the API, so it should be faster.

[Daniel-Dos]

Hi,

here is update to version Junit 5 ?

[keilw]

In indriya, but the API seems unchanged.

[Daniel-Dos]

Hi,

yes, I see what the api still this with version junit 4.12 .

In this case, do we update to version 5?

[keilw]

It's quite an effort because all Unit tests need to be upgraded, some (especially those with expected exceptions) rewritten, but please propose a PR (ideally after https://github.com/unitsofmeasurement/unit-api/pull/111 can be dealt with) for all the necessary changes.

[keilw]

@Daniel-Dos, Although @furlaneto may not be a JCP Associate Member yet, having signed the ECA towards Eclipse is a good first step, maybe you could collaborate on that?

[Daniel-Dos]

Hi ,

wonder, I await the resolution the issue #111

@furlaneto you have me help whit this ?

thanks.

[furlaneto]

@keilw now I'm a JCP member.

@Daniel-Dos I can help you

[keilw]

@furlaneto Thanks a lot. Depending on your membership category, if you would like to join as Expert (need to be Full member) or Contributor (for Associate Members) to show your participation, please fill out the "I want to Join" form on the JSR page: https://jcp.org/en/jsr/detail?id=385 Of course JCP membership is enough to help, so it is up to you if you would like to be visible there or not ;-)

[Daniel-Dos]

wonder @furlaneto , when do you think we can play this issue?

thanks.

[teobais]

I'd like to pick this up before we celebrate the first anniversary of this issue😝 I'm completely new to JUnit 5. However, I already see that the same kind of work has been done for indriya as well; thus, I have a starting point, which is good.

On the other hand, I'm a bit concerned about @keilw 's reference above:

all Unit tests need to be upgraded, some (especially those with expected exceptions) rewritten

So, the question here is: why do we need to update our tests (Java code) as well? I see that by just using the junit-vintage-engine dependency (on top of the rest of required ones for JUnit 5), we don't have to change anything else (Java related).

That is, by only adding the dependencies we added for JUnit 5 migration for indriya, I got some test errors. I then just added junit-vintage-engine dependency as well and the tests passed again.

Isn't that what we want or am I just missing something?

Is there a real need for rewriting the tests according to JUnit 5 standards?

[teobais]

In order to make the ☝️ more clear, I opened a WIP PR for your reference: #152

[teobais]

Closed with #155, #152, #170 and #169