search

unitycatalog / unitycatalog

Open, Multi-modal Catalog for Data & AI
https://unitycatalog.io/
Apache License 2.0
2.46k stars 397 forks source link

Create GitHub Action to deploy docs #308

Open MrPowers opened 4 months ago

MrPowers commented 4 months ago

GitHub action should be clickable and deploy the docs.

Here's the delta-rs GitHub action we use for this task: https://github.com/delta-io/delta-rs/actions/workflows/docs.yml

paulooctavio commented 1 month ago

take

paulooctavio commented 1 month ago

Hey @dennyglee, do I need special permissions to run workflows in my forked repo? The action I'm working on, along with the others, isn’t showing up in the 'Actions' section.

dennyglee commented 1 month ago

Hey @paulooctavio - there should not be any special permissions to run this in your own repo. Can you see the workflows when you go to the .github folder and try to manually execute them?

paulooctavio commented 4 weeks ago

Hey @dennyglee it seems it was just some weird GitHub UI bug, I can see the Actions now. I'm just not entirely sure how to test the Action in the unitycatalog repo. I tested it by setting up a workflow to run on pushes to a test branch in my forked repo, and the deployment was successful.

dennyglee commented 4 weeks ago

Hey @paulooctavio - this seems like it's working on your fork. Can you create a PR to the unitycatalog repo and then one of us can review and test it? Thanks!

paulooctavio commented 3 weeks ago

@dennyglee Sorry, I forgot to mention it, but I already made a PR https://github.com/unitycatalog/unitycatalog/pull/677 to unitycatalog, or is that it not the correct repo yet.

dennyglee commented 3 weeks ago

Oh yeah, I forgot about that one - could you please address comments by @HorizonNet and then feel free to tag me after they yhave been resolved? Thanks!