universAAL / middleware

The core software that uses semantic matchmaking for brokering messages among participants of an open distributed system.
10 stars 3 forks source link

ServiceCall does not implement Matchable #473

Closed cstockloew closed 7 years ago

cstockloew commented 7 years ago

Originally Opened: @Alfiva (2015-07-20 11:24:48) Originally Closed: 2015-07-23 12:16:40

ServiceCall from the Service bus implements UtilityCall which is empty and says

// TODO add matches-methods and parent

It should be implemented by now since there are already components relying on this (Multitenant GW) and failing.

--

From: this issue has been automatically imported from our old issue tracker

cstockloew commented 7 years ago

Original author: @cstockloew (2015-07-22 15:41:27)

This was a left-over from an early version. I removed the comment; thanks for noticing.

A ServiceCall (as well as ServceResponse, UIResponse etc) is not a Matchable. Although it is transferred via the bus, it is not used for Matchmaking, but rather contain - in case of a ServiceCall - something like the matching result. Therefore a matches-method does not make sense.

If you want a base class for all bus messages you can only take Resource, and check for each instance if it is instanceof Matchable..

cstockloew commented 7 years ago

Original author: @Alfiva (2015-07-23 08:29:14)

I don't mind it not being a Matchable, but the Mt GW uses it as such (and fails when casting to Matchable). Then the GW should be fixed to not rely on this - but I don't know how. If ServiceCall is never going to be a Matchable then you can simply close this item.

cstockloew commented 7 years ago

issue cloed on 2015-07-23 12:16:40