search

univrsal / tuna

Song information plugin for obs-studio
GNU General Public License v2.0
752 stars 59 forks source link

Add Pretzel support #147

Closed mihawk90 closed 3 years ago

mihawk90 commented 3 years ago

This is adding support for Pretzel.rocks. Although they do have a Desktop Application with a filewriting feature, it is Windows only, so this is helpful mainly for Linux and Mac users.

Split into 3 commits:

  1. The original file currently on Greasyfork

  2. The actual support for Pretzel It is unfortunately a little hacky, but I currently see no other way of implementing it. There is no change in states anywhere on the page that I could select for the play status, and neither is there an <audio> element I could query the status of. The only thing changing is the icon on the Play/Pause button. The way this is done is not a class-swap, but simply replacing the SVG within. So the workaround is selecting part of the <path> SVG element that is unique to both icons. I hope the class names I used for selecting are not changing anytime soon, but again, I couldn't find anything else unique.

  3. A small change that makes the setInterval() actually use the configured refresh rate, previously it was only being used for the cooldown reduction.

One note/question: Is the album_url supposed to contain only the album name, or the actual url? SoundCloud and Spotify both use the actual URL, while Yandex only sends the title, and Deezer doesn't send anything at all. I'm not entirely sure what the point of writing the URL would be though considering this is probably just going on an overlay?

univrsal commented 3 years ago

The album url should contain the link to the album image file so tuna can download it or it can be forwarded to the browser source.

univrsal commented 3 years ago

Is there anything that you want to do before this should be merged?

mihawk90 commented 3 years ago

The album url should contain the link to the album image file so tuna can download it or it can be forwarded to the browser source.

Hm I thought this was what cover_url is for? And that is being downloaded already just fine :thinking:

Is there anything that you want to do before this should be merged?

Just the question above, it seems to work fine otherwise :) I also asked on the Pretzel discord if there might be a chance we get a more unique identifier for selecting the elements then just the classes, but I didn't get an answer from any of the devs yet :sweat_smile: But I can just make a new PR if anything gets implemented :)

univrsal commented 3 years ago

The album url should contain the link to the album image file so tuna can download it or it can be forwarded to the browser source.

Hm I thought this was what cover_url is for? And that is being downloaded already just fine thinking

Is there anything that you want to do before this should be merged?

Just the question above, it seems to work fine otherwise :) I also asked on the Pretzel discord if there might be a chance we get a more unique identifier for selecting the elements then just the classes, but I didn't get an answer from any of the devs yet sweat_smile But I can just make a new PR if anything gets implemented :)

I just checked and cover_url is the link for the cover image file and album_url is unused, I guess it's just leftover from testing or something.

mihawk90 commented 3 years ago

OK then it can be merged :) Thank you