unmojang / FjordLauncher

Prism Launcher fork with support for alternative auth servers
GNU General Public License v3.0
96 stars 18 forks source link

Merge changes from Prism Launcher 9.1 #38

Closed evan-goode closed 1 month ago

evan-goode commented 1 month ago

Prism Launcher 9.0 made substantial changes to the authentication logic (https://github.com/PrismLauncher/PrismLauncher/pull/2402), so this merge involved a lot of refactoring and rewriting the authlib-injector authentication code to match Prism Launcher's new structure. But the error handling while adding a new authlib-injector account is now much nicer (no more "Mojang user authentication ended in a network error").

I'd really appreciate volunteers to test this before it's released!

Suggested things to test:

LunaisLazier commented 1 month ago

Modrinth and FTB App Import both seem to have this extra unusable search bar at the bottom(?) image This is not the case in upstream Prism 9.1

LunaisLazier commented 1 month ago

The add mojang button from the current version of fjord is also missing, is this intentional?

catfromplan9 commented 1 month ago

The add mojang button from the current version of fjord is also missing, is this intentional?

Mojang accounts do not exist anymore, so yes

catfromplan9 commented 1 month ago

Modrinth and FTB App Import both seem to have this extra unusable search bar at the bottom(?) image This is not the case in upstream Prism 9.1

Could you show an image of how it looks in upstream prism?

LunaisLazier commented 1 month ago

The add mojang button from the current version of fjord is also missing, is this intentional?

Mojang accounts do not exist anymore, so yes

Yet the previous version of Fjord still has the option there, and microsoft accounts haven't existed for over a year.

LunaisLazier commented 1 month ago

Modrinth and FTB App Import both seem to have this extra unusable search bar at the bottom(?) image This is not the case in upstream Prism 9.1

Could you show an image of how it looks in upstream prism? image

image

evan-goode commented 1 month ago

Removing the Mojang account button was intentional, no reason to keep it around any longer. I might as well go ahead and rip out more of the Mojang account logic while I'm at it, like Prism already has.

I'll look into that search bar.

evan-goode commented 1 month ago

Not sure where those search bars came from :)

I think everything is good to go, I will merge soon unless something else is found.

LunaisLazier commented 1 month ago

Presuming the removal of the PollyMC contributors credit in the about section was intentional, I haven't come across any issues since!

evan-goode commented 1 month ago

Presuming the removal of the PollyMC contributors credit in the about section was intentional, I haven't come across any issues since!

Yeah, that was a (old) change from upstream.

LunaisLazier commented 1 month ago

Polly with two Ls, not the one under Lenny but understood!

evan-goode commented 1 month ago

Oh whoops, no that was a mistake, I'll add that back.

catfromplan9 commented 4 weeks ago

Presuming the removal of the PollyMC contributors credit in the about section was intentional, I haven't come across any issues since!

Yeah, that was a (old) change from upstream.

I think this should be reverted

evan-goode commented 4 weeks ago

It was reverted.