Closed brianberlin closed 5 years ago
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
lib/mix/tasks/licenses.ex | 1 | 50.0% | ||
lib/licensir/guesser.ex | 1 | 88.89% | ||
lib/licensir/file_analyzer.ex | 9 | 0.0% | ||
lib/licensir/scanner.ex | 16 | 15.0% | ||
<!-- | Total: | 27 | --> |
Totals | |
---|---|
Change from base Build 19: | -58.7% |
Covered Lines: | 17 |
Relevant Lines: | 46 |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
lib/mix/tasks/licenses.ex | 1 | 50.0% | ||
lib/licensir/guesser.ex | 1 | 88.89% | ||
lib/licensir/file_analyzer.ex | 9 | 0.0% | ||
lib/licensir/scanner.ex | 16 | 15.0% | ||
<!-- | Total: | 27 | --> |
Totals | |
---|---|
Change from base Build 19: | -58.7% |
Covered Lines: | 17 |
Relevant Lines: | 46 |
Thank you! Before I merge, do you have any idea why these 2 lines of change could drop the code coverage by 58.7%?
It looks like travis ran with elixir 1.5 and 1.6. It's not until 1.7 that Mix.Dep.load_on_environment/1
is available. I'm not sure about the travis config change and I don't really like the extra conditional to call the correct function. What do you think?
Given that this is a dev tool, I don't mind too much about that extra condition. We could remove it when 1.6 is a little older.
Thank you for your help!