search

unoconv / unoserver

MIT License
552 stars 77 forks source link

fix: windows incompatibilities #36

Closed ankology closed 1 year ago

ankology commented 2 years ago

Hi guys! Thanks for the project. Today i managed to work with unoserver in windows, and i have a fell breakpoints.

1) In server.py when executing in windows the command f"-env:UserInstallation={self.tmp_uri}" displays a strange error see example, seems not necessary for soffice.exe that command. So, i added a Linux verification to append it.

2) In server.py when executing in windows, the process crashes because not exists a signal SIGHUP in Windows envrionment, so i added a verification as well.

By change that, works like a charm! Please consider the pull request for Windows users. Thanks again!

Edit 1: The issue with Windows is because the temporary uri generation gives an invalid path to process creation, causing the error, commit fixed.

ankology commented 2 years ago

Fixed. Please review the changes! @mara004

mara004 commented 2 years ago

Thanks, looks pretty good now! Have you tested the changes? In particular, I wasn't very sure if the pathlib bit would actually work on Windows.

ankology commented 2 years ago

@mara004 Yes, i'm currently using in Windows, it's working fine!! ;)

mara004 commented 2 years ago

@ankology Great, thanks for your work!

regebro commented 1 year ago

Thanks to everyone for this!