Closed Youssef1313 closed 2 months ago
cc @jeromelaban @ebariche
This one is quite important I think?
NOTE:
In BuildDist
, we are doing this:
<ItemGroup>
<StaticWebAsset Remove="@(StaticWebAsset)" />
</ItemGroup>
<StaticWebAssetsResolverTask_v141bdf179d88790116104b9a8c602bc694813ebc
WebAppBasePath="$(WasmShellWebAppBasePath)"
DistPath="$(WasmShellOutputDistPath)"
AssemblyName="$(AssemblyName)"
ProjectDirectory="$(MSBuildProjectDirectory)">
<Output TaskParameter="StaticWebAsset" ItemName="StaticWebAsset" />
</StaticWebAssetsResolverTask_v141bdf179d88790116104b9a8c602bc694813ebc>
The removed StaticWebAsset
has the correct metadata, but then StaticWebAssetsResolverTask
adds StaticWebAsset back with missing Fingerprint
and Identity
And this is how it should be calculated:
PR https://github.com/dotnet/sdk/pull/39405 was merged into Preview 4 and has broke our task.
Our task has
StaticWebAsset
output which is now missingFingerprint
andIntegrity
metadata, causing failures like:Here is our currently defined metadata:
https://github.com/unoplatform/Uno.Wasm.Bootstrap/blob/72de499bc1f8cdba304ad4b156c259e0833398f7/src/Uno.Wasm.Bootstrap/StaticWebAssetsResolverTask.cs#L76-L84
Here is what .NET expects:
https://github.com/dotnet/sdk/blob/d665fdf4adeb9b4b6b874e324ffa9a8f76c6edc9/src/StaticWebAssetsSdk/Tasks/Data/StaticWebAsset.cs#L283-L301
The
Fingerprint
andIdentity
ones are required:https://github.com/dotnet/sdk/blob/d665fdf4adeb9b4b6b874e324ffa9a8f76c6edc9/src/StaticWebAssetsSdk/Tasks/Data/StaticWebAsset.cs#L383-L391