unoplatform / uno.toolkit.ui

A set of custom controls for the WinUI and the Uno Platform not offered out of the box by WinUI, such as Card, TabBar, NavigationBar, etc.
https://platform.uno/
MIT License
83 stars 27 forks source link

[IOS] No native/default back button when doing modal navigation. #675

Open Marc-Antoine-Soucy opened 1 year ago

Marc-Antoine-Soucy commented 1 year ago

Current behavior

When doing a modal navigation on a route that does not have a depends on, the navigation button is either not there or invisible (if the MainCommand is not defined.

Expected behavior

The default button should be visible if you can navigate back.

How to reproduce it (as minimally and precisely as possible)

Reprosample.zip Comment out the NavigationBar on SecondPage. Run app and click on the "Go to Second Page with modal navigation" If run on Windows - SecondPage has a back button If run on iOS - SecondPage doesn't have a back button

image

Environment

Nuget Package:

<PackageVersion Include="Uno.Extensions.Configuration" Version="3.0.0-dev.1984" />
    <PackageVersion Include="Uno.Extensions.Hosting" Version="2.4.2" />
    <PackageVersion Include="Uno.Extensions.Hosting.WinUI" Version="3.0.0-dev.1984" />
    <PackageVersion Include="Uno.Extensions.Http" Version="3.0.0-dev.1984" />
    <PackageVersion Include="Uno.Extensions.Http.Refit" Version="3.0.0-dev.1984" />
    <PackageVersion Include="Uno.Extensions.Localization" Version="2.4.2" />
    <PackageVersion Include="Uno.Extensions.Localization.WinUI" Version="3.0.0-dev.1984" />
    <PackageVersion Include="Uno.Extensions.Logging.OSLog" Version="1.6.0-dev.2" />
    <PackageVersion Include="Uno.Extensions.Logging.WebAssembly.Console" Version="1.6.0-dev.2" />
    <PackageVersion Include="Uno.Extensions.Logging.WinUI" Version="3.0.0-dev.1984" />
    <PackageVersion Include="Uno.Extensions.Navigation" Version="2.4.2" />
    <PackageVersion Include="Uno.Extensions.Navigation.WinUI" Version="3.0.0-dev.1984" />
    <PackageVersion Include="Uno.Extensions.Navigation.Toolkit.WinUI" Version="3.0.0-dev.1984" />
    <PackageVersion Include="Uno.Extensions.Reactive" Version="2.4.2" />
    <PackageVersion Include="Uno.Extensions.Reactive.WinUI" Version="3.0.0-dev.1984" />
    <PackageVersion Include="Uno.Extensions.Serialization" Version="2.4.2" />
    <PackageVersion Include="Uno.Extensions.Serialization.Http" Version="3.0.0-dev.1984" />
    <PackageVersion Include="Uno.Extensions.Serialization.Refit" Version="3.0.0-dev.1984" />
    <PackageVersion Include="Uno.Material.WinUI" Version="3.0.0-dev.264" />
    <PackageVersion Include="Uno.Dsp.Tasks" Version="1.1.0" />
    <PackageVersion Include="Uno.Toolkit.WinUI" Version="4.0.0-dev.52" />
    <PackageVersion Include="Uno.Extensions.Toolkit.WinUI" Version="3.0.0-dev.1984" />
    <PackageVersion Include="Uno.Toolkit.WinUI.Material" Version="4.0.0-dev.52" />
    <PackageVersion Include="Uno.Resizetizer" Version="1.2.0-dev.19" />
    <PackageVersion Include="Uno.UI.Adapter.Microsoft.Extensions.Logging" Version="5.0.0-dev.1433" />
    <PackageVersion Include="Uno.UniversalImageLoader" Version="1.9.36" />
    <PackageVersion Include="Uno.Wasm.Bootstrap" Version="8.0.0-dev.226" />
    <PackageVersion Include="Uno.Wasm.Bootstrap.DevServer" Version="8.0.0-dev.226" />
    <PackageVersion Include="Uno.Wasm.Bootstrap.Server" Version="8.0.0-dev.226" />
    <PackageVersion Include="Uno.WinUI" Version="5.0.0-dev.1433" />
    <PackageVersion Include="Uno.WinUI.RemoteControl" Version="5.0.0-dev.1433" />
    <PackageVersion Include="Uno.WinUI.Skia.Gtk" Version="5.0.0-dev.1433" />
    <PackageVersion Include="Uno.WinUI.WebAssembly" Version="5.0.0-dev.1433" />

Package Version(s):

Affected platform(s):

Visual Studio:

Relevant plugins:

Anything else we need to know?

I am not entirely sure if what is shown in the sample is a bug, or if its a bug that should be in toolkit.

nickrandolph commented 1 year ago

@kazo0 shifted this to toolkit as need your assistance working out why the back button appears on windows but not ios