[Android] TextBox with TranslateTransform show incorrect system menus

jeromelaban commented 5 years ago

Current behavior

System menus of a translated TextBox are placed incorrectly.

<TextBox 
    TextWrapping="Wrap"
    AcceptsReturn="True"
    PlaceholderText="Text Message"
    VerticalAlignment="Center"
    Margin="0,0,44,0">
    <TextBox.RenderTransform>
        <TranslateTransform Y="-50"/>
    </TextBox.RenderTransform>
</TextBox>

Expected behavior

How to reproduce it (as minimally and precisely as possible)

Use the following repo: KeyboardOverlapIssue.zip
Type some text in the textbox
Double tap to select the content

Notice that the system menu is not at the correct position:

Environment

Nuget Package: 2.0.512-dev.3644

Affected platform(s):

[ ] iOS
[x] Android
[ ] WebAssembly
[ ] WebAssembly renderers for Xamarin.Forms
[ ] Windows
[ ] Build tasks
[ ] Solution Templates

Visual Studio:

[ ] 2017 (version: )
[ ] 2019 (version: )
[ ] for Mac (version: )

Relevant plugins:

[ ] Resharper (version: )

Anything else we need to know?

https://nventive.visualstudio.com/Umbrella/_workitems/edit/164383

davidjohnoliver commented 5 years ago

This is a tricky one. The positioning logic calls internal methods we can't override (which don't take getChildStaticTransformation() into account). It also seems to be heavily version-dependent: if I override the GetLocationInWindow() and GetGlobalVisibleRect() methods on TextBoxView, it 1) fixes the problem on an Android 6 device, 2) fixes the copy-paste toolbar but not the selection markers on an Android 7 device, and 3) doesn't fix either problem on an Android 8.1 device.

MatFillion commented 4 years ago

@davidjohnoliver @jeromelaban as this one seems pretty complex, can we suggest an alternative approach for someone who would like to translate a textbox? Since using TranslateTransform causes issues.

jeromelaban commented 4 years ago

I some options:

Is the creation of a second TextBox at the location when the keyboard is opened possible? Animating the first one up to the proper location, and hide it while the user edits.
Create the TextBox at the location where the keyboard is opened, then translate it to the location where the system cues don't happen ?
Animate, then replace the transform with a margin or padding

unoplatform / uno