search

unoplatform / uno

Open-source platform for building cross-platform native Mobile, Web, Desktop and Embedded apps quickly. Create rich, C#/XAML, single-codebase apps from any IDE. Hot Reload included! 90m+ NuGet Downloads!!
https://platform.uno
Apache License 2.0
9.08k stars 736 forks source link

[Gallery][Skia.GTK/MacOS] Light/dark theme change toggle button is not working properly for most of the controls like Textbox, Toggleswitch, Timepicker #7201

Open sakshi173 opened 3 years ago

sakshi173 commented 3 years ago

Current behavior

https://user-images.githubusercontent.com/74563602/170562530-6d2e7f52-82a7-4d0d-82a5-3574ddcb57ee.mp4

Expected behavior

The Day/Night theme change toggle button should work for each control.

https://user-images.githubusercontent.com/74563602/170562963-8979b59e-21cf-45f1-aecd-129ffc9fb6ca.mp4

How to reproduce it (as minimally and precisely as possible)

Launch the Uno.Gallry app on Skia.GTK Click on 'Textbox' OR 'TimePicker' or 'ToggleSwitch' from the 'Component' list. Click on the Day/Night theme change toggle button. Observe that Day/Night theme change toggle button is not working and by default always 'Card' controls window opens.

Workaround

No response

Works on UWP/WinUI

No response

Environment

No response

NuGet package version(s)

No response

Affected platforms

Skia (GTK on Linux/macOS/Windows)

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response

Xiaoy312 commented 2 years ago

no longer able to repro:

sakshi173 commented 2 years ago

The issue is still happening Due to that reopening the bug. Below are the steps.

  1. Launch the Uno.Gallry app on Skia.GTK.
  2. Firstly click on any controls like "Brush" from 'Features' list.
  3. Now Click on the Day/Night theme change toggle button.
  4. Ensure that the theme is in Dark mode.
  5. Now click on 'PasswordBox' control.
  6. Now again Click on the Day/Night theme change toggle button to change the theme.
  7. Notice that theme is not changing and ElevatedView page opened.
MartinZikmund commented 1 year ago

This was most likely related to pointers not hit testing correctly, but this is now most likely not happening. Can be verified and if ok, closed.

jeromelaban commented 1 year ago

@sakshi173

agneszitte commented 1 year ago

Added to the "Needs QA Review" list for @sakshi1, depending on the outcome will see the priority of the issue. Placed in the current main release for now but can be moved if still happening and needs to be fixed but is low priority.

MartinZikmund commented 6 months ago

This is most likely fixed

agneszitte commented 6 months ago

@sakshi173 can you retest this one please