search

unsay / vicini

9 stars 1 forks source link

Angular rails form style #5

Closed unsay closed 11 years ago

unsay commented 11 years ago

@jdalt I'm thinking this is good. Less hacky and lib-y.

Using normal Rails helpers with a dumb HAML form tag, it removes simple_form as a dependency, no url = '' hack (it's a Rails form_for thing), so we would need to skip the object helpers.

unsay commented 11 years ago

Also, this pull request is into angular_refactor, not master. Just wanted to make the thoughts clear (not mucked up with the long list of things on the other branch).

jdalt commented 11 years ago

This is a small change. Do I just merge it back in or should we change the profile and user forms to match this first?

unsay commented 11 years ago

It's small for number of lines, though huge for style and approaching how we integrate Angular and Rails. I say merge! It's settled how we approach building forms and connecting services.