search

up-for-grabs / up-for-grabs.net

This is a list of projects which have curated tasks specifically for new contributors. These issues are a great way to get started with a project, or to help share the load of working on open source projects. Jump in!
https://up-for-grabs.net/
Other
5.42k stars 2.08k forks source link

Update Yo tool to match current template #2399

Open preetkaran20 opened 4 years ago

preetkaran20 commented 4 years ago

Hi Team,

I have recently added my Project Owasp VulnerableApp to the up-for-grabs using YO generator and i found that there are gaps between the tool and the actual requirement of the PR(Build Actions) and hence user has to-fro multiple times as an example: Tools doesn't have validations or at a minimal text help which mentioned validations like : is not allowed or space in tags is not allowed, lower-case letters are only allowed etc.

I think validations should be added to YO generator tool and if not possible please add text mentioning the same at each input step. I think it is important.

thanks, Karan

preetkaran20 commented 4 years ago

PR where i faced this issue: https://github.com/up-for-grabs/up-for-grabs.net/pull/2380

ritwik12 commented 4 years ago

@preetkaran20 Thanks for opening this :)

shiftkey commented 4 years ago

@preetkaran20 thanks for the heads up - you're right that it's very out of date with what we currently support and probably needs some improvements. We have the code available over in https://github.com/up-for-grabs/generator-up-for-grabs but I haven't had time to dig into what needs to change. I'm also not that familiar with how it works.

If we find ourselves needing to publish a new update to NPM I'll need to ask @ChrisMissal for access on NPM.

g-kabra commented 2 years ago

Hey! I'd like to try solving this issue. At the very least, I can add messages regarding the format of expected input, and if possible, I will try to add regex filters which will check if input is of the correct form. I will need a list of validations to be performed though, a few are listed in the issue, but it would be easier for me to have a full list so as to make a comprehensive validation filter.

shiftkey commented 2 years ago

@g-kabra I'm very hazy on what's needed here but feel free to take a shot at it

g-kabra commented 2 years ago

Hey @shiftkey . I've tried implementing what I understood from the issue here. Check out my PR over here. Let me know if it works for you or needs any changes!

Ashcjs commented 2 years ago

Backup-codes-pitreb913.txt

Have you finished this file yet?Backup-codes-pitreb913.txt

Have you finished this file yet?Backup-codes-pitreb913.txt

Have you finished this file yet?Backup-codes-pitreb913.txt

Have you finished this file yet?

Ashcjs commented 2 years ago

_data/projects/Appsmith.yml