Upgrade logstore_xapi plugin

michzimny commented 5 years ago

@athird, could we ask someone to prepare an upgrade of the logstore_xapi plugin, probably to the latest version?

michzimny commented 5 years ago

@gtoffoli, could you please decide or assess whether it's needed to upgrade this plugin in Moodle?

gtoffoli commented 5 years ago

@michzimny, @athird, @nadavkav, I don't know how much this is important. From https://github.com/xAPI-vle/moodle-logstore_xapi it seems that during the last 4-8 months there were only a few (minor?) bug fixes. Rather, I have other questions:

what do you think about my remarks (https://github.com/up2university/DSpace/issues/4) on the current implementation of the xAPI integration of DSpace? there would be somebody able and willing to extend the moodle-logstore_xapi according to my suggestions?
I know that H5P is able to generate events useful for sending xAPI statements (https://h5p.org/documentation/x-api), but I don't understand if, when H5P is integrated into Moodle, to become effective this requires an extension of the moodle-logstore_xapi and/or some specific configuration; who could answer? In my view this issue has a higher priority
I'm not a Moodle expert nor a PHP programmer, but some time ago, by inspecting the code of the moodle-logstore_xapi, I got the impression that its code has poor modularity; it seems that, every time a new Moodle plugin is added, you have to extend the code of the moodle-logstore_xapi to map new events to xAPI statements. Is my impression correct?

nadavkav commented 5 years ago

@gtoffoli , looking at the list of changes in moodle-logstore_xapi from the UP2U version (2.2.3) https://learn.up2university.eu/admin/plugins.php?updatesonly=0&contribonly=1 to the latest (4.2.5) version: https://github.com/xAPI-vle/moodle-logstore_xapi/releases It seems like a lot of important changes. I advise upgrading the plugin.

H5P xAPI events can not be used directly. When used in Moodle, they are sent from the user's browser into Moodle, and not sent to the LRS via the moodle-logstore_xapi plugin. they are used internally by the H5P module to monitor user (student) progress and grades. then, some of them (very few) are converted into Moodle events. but are not sent to the LRS.

It looks very interesting and useful to add xAPI support to DSpace, as you did in: https://github.com/up2university/DSpace/issues/4 Great work!

Callustian commented 5 years ago

@gtoffoli Thank you for your message, @nadavkav Thank you for your reply. (also @athird and @michzimny )

Out team is making 2 releases ready. One shall add several fixes to the current version of Moodle, and the other one shall change the version of Moodle to 3.6.2.

Moodle 3.6.2 has version 4.2.2 of Logstore xAPI. Therefore if this is not the version you need, I shall have to add the version of Logstore xAPI you need to a release. Therefore I need to know if the version of Logstore xAPI you need is for the current version of Moodle or for 3.6.2. Thanks.

gtoffoli commented 5 years ago

@nadavkav Thanks for all answers. Ok, I was wrong about the need of having an upgrade of the logstore_xapi plugin. As to DSpace, it wasn't me who added xAPI support; rather, I expressed some doubts about the way it was done. @Callustian Sorry, but I am not able to choose; I'm not familiar with Moodle, its releases and the compatibility of the versions of its plugins.

up2university / docker-moodle

Upgrade logstore_xapi plugin #111