search

uperl / AnyEvent-WebSocket-Client

WebSocket client for AnyEvent
9 stars 10 forks source link

Protocol error: reserved close code #61

Closed schmorp closed 1 year ago

schmorp commented 1 year ago

Currently, this module sends a reserved close code (1005) on connection close (in AnyEvent::WebSocket::Connection), which is a protocol violation. It should default to a valid code, such as 1000 (or possibly 1001).

plicease commented 1 year ago

I agree should be 1000.

plicease commented 1 year ago

@debug-ito Are there any ramifications to AnyEvent::WebSocket::Server if I change the default code for close?

debug-ito commented 1 year ago

I think it's ok to change the default code.

plicease commented 1 year ago

Fixed in 0.55.