search

upes-open / MediaMorph

A Chrome extension enhancing video player functionalities: control video speed, adjust sound up to 200%, OCR for copying text, clickable video links, picture-in-picture, and video controls for YouTube shorts.
3 stars 3 forks source link

Added volume control functionality #17

Closed virajp4 closed 1 year ago

virajp4 commented 1 year ago

This PR fixes the issue #4 . (It shows 2 commits because I mistakenly added yesterdays commit into the upstream.) closes: #4

NavySaw23 commented 1 year ago

Hello Viraj, after going through the code I found out that it doesn't fix the intended issue.

The goal is to amplify the sound once the user has exceeded 100% on the slider, but currently, the provided code works by mapping the existing volume slider in 200 parts (i.e. in increments of 0.5) and keeps the range at 0-100%. The intended feature would be to keep the increments to 1% and amplify the volume if the slider goes above 100%.

Hence the PR cannot be merged.

virajp4 commented 1 year ago

understood, will fix that.

virajp4 commented 1 year ago

@NavySaw23 fixed the code using web audio api

NavySaw23 commented 1 year ago

Thank you for your contribution @virajp4