search

upgrades-migrations / preupgrade-assistant-modules

Modules for the Preupgrade Assistant tool. Disclaimer: It was fun. R.I.P. :-)
GNU General Public License v3.0
3 stars 11 forks source link

cryptsetup uses INFO for DEBUG msgs #37

Open pirat89 opened 6 years ago

pirat89 commented 6 years ago

The cryptsetup-luks module (xccdf_preupg_rule_storage_cryptsetup-luks_check) uses prints info messages even when the result is PASS. From my point of view, the messages are more like debug msgs as they don't carry any useful information for the user:

preupg.log.INFO: Checking devices in /root/preupgrade/etc/crypttab
preupg.log.INFO: Check remaining devices on the system by using blkid.

In addition, msg would be changed, as /root/preupgrade/etc/crypttab is not probably the happiest solution.

EDIT: whoever will look at this, the one should investigate whole functionality of the module.

pirat89 commented 6 years ago

In addition, the file really should not be present on this path

AloisMahdal commented 6 years ago

The Check remaining devices on the system by using blkid looks like instruction rather than debug detail. Maybe it could be removed altogether?