Use Gopkg.toml instead of manifest.json - Bump goruntime from 1.8 to 1.11

upmc-enterprises / registry-creds

Allow for AWS ECR, Google Registry, & Azure Container Registry credentials to be refreshed inside your Kubernetes cluster via ImagePullSecrets

Other

344 stars 124 forks source link

Use Gopkg.toml instead of manifest.json - Bump goruntime from 1.8 to 1.11 #73

Closed nvanheuverzwijn closed 2 years ago

nvanheuverzwijn commented 5 years ago

Description

The current version of dep this repository is using is an old version. This PR use the latest version of go dep. This PR also bump the go runtime from 1.8 to 1.11.

What it does

manifest.json and lock.json are replaced with Gopkg.toml and Gopkg.lock. Test packages are removed from vendor directory.

How this patch was acheived

Command go dep init was used to generate Gopkg.toml and Gopkg.lock. Test were run locally with make build and make test.

nvanheuverzwijn commented 5 years ago

@stevesloka Are you open to create a new binary on Go 1.11 ?

stevesloka commented 4 years ago

Hey @nvanheuverzwijn thanks for the PR. Would you mind re-doing this in go modules? We should also bump the k8s version along with the go version. Thanks!

nvanheuverzwijn commented 4 years ago

@stevesloka I must admit that I am not too familiar with Go so I am not too sure what it means to redo this in Go modules :(