search

upstash / wikipedia-semantic-search

Semantic Search on Wikipedia with Upstash Vector
https://wikipedia-semantic-search.vercel.app/
MIT License
424 stars 35 forks source link

refactor(layout): move header from page to layout #7

Closed hanifisenturk closed 2 months ago

hanifisenturk commented 2 months ago

Hi!

I noticed that the Header component is being used on the index page, but since it's not specific to this page, I moved it to layout.tsx.

vercel[bot] commented 2 months ago

@hanifisenturk is attempting to deploy a commit to the Upstash Team on Vercel.

A member of the Team first needs to authorize it.

ytkimirti commented 2 months ago

I know this might be the correct way of doing this but since we are doing a single page app, I think this is not needed. It's better used when you have multiple nested routes using the same header. But still, thanks a lot for the PR, appreciate it 🙏