IdService wastes IDs on read misses

urbanairship / datacube

Multidimensional data storage with rollups for numerical data

http://urbanairship.com

Apache License 2.0

266 stars 60 forks source link

IdService wastes IDs on read misses #34

Closed drevell closed 6 years ago

drevell commented 12 years ago

When looking up an address contaning a field value that doesn't exist, IdService will allocate a unique ID for that field value. Reads should never allocate unique IDs.

IdService.getId(int dimensionNum, byte[] input, int numIdBytes)

should change to something like

IdService.getId(int dimensionNum, byte[] input, int numIdBytes, boolean allocateIfAbsent)

AWinterman commented 8 years ago

addressed in https://github.com/urbanairship/datacube/pull/61