search

urbanairship / ios-library

Urban Airship iOS SDK
http://urbanairship.com
Apache License 2.0
478 stars 265 forks source link

Thread Performance Checker Issue #394

Closed nomimalik92 closed 5 months ago

nomimalik92 commented 5 months ago

What Airship dependencies are you using? iOS SDK and Version 16.12.4

What are the versions of any relevant development tools you are using? XCode 15.3

What unexpected behavior are you seeing? I am getting this thread performance issue in logs.

What expected behavior I am looking for? This thread performance should not be here.

Do you have logging for the issue? Attaching screenshot of logs.

image
rlepinski commented 5 months ago

This issue was fixed in 17.x

nomimalik92 commented 5 months ago

What about those user who can't update their SDK to 17.0. Because of minimum target restriction. Our app minimum version is iOS 12 and we can't update SDK to 17.0. So there should be a fix for this. What you think?

nomimalik92 commented 5 months ago

@rlepinski

rlepinski commented 5 months ago

I looked into the issue and it appears that we are doing everything on a utility queue, not user initiated. I logged the queue and got this: Queue com.urbanairship.dispatcher.serial_queue#DispatchQoS(qosClass: Dispatch.DispatchQoS.QoSClass.utility, relativePriority: 0)

These are warnings, they are not causing enough issues to patch a now 2 major version back release. Its just not worth the risk IMO. If we determine the root cause we can consider a patch but at the moment it looks like it might be addressed by apple eventually.