urinieto / msaf

Music Structure Analysis Framework
MIT License
501 stars 79 forks source link

ImportError: cannot import name 'factorial' from 'scipy.misc' #119

Closed oriolcolomefont closed 1 year ago

oriolcolomefont commented 1 year ago

Hi there, First, I'd like to thank @urinieto for such a fantastic tool.

When importing the package in either Google Colab or on my IDE (PyCharm), the error message "ImportError: cannot import name 'factorial' from 'scipy.misc.common' (/usr/local/lib/python3.8/dist-packages/scipy/misc/common.py)" pops up.

Captura de pantalla 2023-01-03 a les 17 37 18

As a side note, the message features: "NOTE: If your import is failing due to a missing package, you can manually install dependencies using either !pip or !apt." However, all the conditions regarding scipy's installation seem to be satisfied.

Captura de pantalla 2023-01-03 a les 17 42 30

On top of that, that submodule doesn't seem to exist anymore.

Captura de pantalla 2023-01-03 a les 17 44 04

Could someone please let me know about this? Thanks!

urinieto commented 1 year ago

This was reported here: https://github.com/urinieto/msaf/issues/113

Try with the latest version in main of this repo, it should be fixed there (see this line: https://github.com/urinieto/msaf/blob/master/msaf/pymf/vol.py#L19).

Thanks for reporting!

oriolcolomefont commented 1 year ago

Thank YOU @urinieto

oriolcolomefont commented 1 year ago

@urinieto Even though I see the issue fixed here https://github.com/urinieto/msaf/blob/master/msaf/pymf/vol.py#L19 I am still struggling with the latest version in the main of this repo. I am not able to execute it. Am I missing something? Could you please shed some light on this? Thanks!

urinieto commented 1 year ago

You should be able to make it work using the latest version (master branch). Make sure you have uninstalled whatever version you installed from PyPi, and then install it from source.