fix: Allows urql-devtools to launch via Windows PowerShell

urql-graphql / urql-devtools

A tool for monitoring and debugging urql during development

https://formidable.com/open-source/urql/docs/advanced/debugging/#devtools

MIT License

259 stars 11 forks source link

fix: Allows urql-devtools to launch via Windows PowerShell #378

Closed jakobo closed 3 years ago

jakobo commented 3 years ago

Resolves an issue where in powershell "npm" is not a valid command, and uses the correct "npm.cmd" executable instead. Test plan ran since checkout on windows has issues:

install globally via npm install -g urql-devtools
cd into the AppData/roaming directory for node_modules
make change directly to the cli.js file
launch using the global bin command "urql-devtools"

Fixes: #377

andyrichardson commented 3 years ago

@jakobo on second thought - have you set up your path correctly?

I think the current state will work fine as long as npm is correctly set in your path.

andyrichardson commented 3 years ago

Closing for now (see #377)

andyrichardson commented 3 years ago

Reopening as it looks like we have confirmation this isn't a path/environment issue

jakobo commented 3 years ago

Hey all, anything you need from me to get this over the line?

As an alternative, we can also spawn with shell:true as long as we're comfortable with the shell requirements for that spawn option

The shell should understand the -c switch. If the shell is 'cmd.exe', it should understand the /d /s /c switches and command-line parsing should be compatible.

Default: '/bin/sh' on Unix, process.env.ComSpec on Windows.

Official Documentation: https://nodejs.org/api/child_process.html#spawning-bat-and-cmd-files-on-windows

andyrichardson commented 3 years ago

Apologies @jakobo lets get this in :+1: