usdot-fhwa-OPS / V2X-Hub

V2X Hub is a message handler that acts as a translator and data aggregator/disseminator for infrastructure components of a connected vehicle deployment.

118 stars 67 forks source link

Vh 1216 fix spat plugin segfault simulation #621

Open paulbourelly999 opened 1 week ago

paulbourelly999 commented 1 week ago

PR Details

Description

This pull request updates the SPAT plugin to fix a number of issues with the legacy implementation.

Overly complex legacy code
Reduced duplication using existing objects for SNMP Client and UDP Server
Reduced use of raw pointers
Improved documentation
Fix SNMP Client to have working SNMP Set implementation
Added unit testing
Added functionality to consume J2735 UPER HEX SPaT from signal controller.

Related Issue

Motivation and Context

Fix SPaT plugin for simulation and improve overall usability and maintainability.

How Has This Been Tested?

Tested using virtual signal controller for both binary and hex spat payloads.

Types of changes

[x] Defect fix (non-breaking change that fixes an issue)
[x] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that cause existing functionality to change)

Checklist:

[ ] I have added any new packages to the sonar-scanner.properties file
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document. V2XHUB Contributing Guide
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

sonarcloud[bot] commented 2 days ago

Quality Gate failed

Failed conditions
40.67% Line Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud