usdot-fhwa-stol / carma-platform

CARMA Platform is built on robot operating system (ROS) and utilizes open source software (OSS) that enables Cooperative Driving Automation (CDA) features to allow Automated Driving Systems to interact and cooperate with infrastructure and other vehicles through communication. Doxygen Source Code Documentation :
https://usdot-fhwa-stol.github.io/documentation/carma-platform/
403 stars 124 forks source link

Fix carma exec gui #2428

Closed MishkaMN closed 3 months ago

MishkaMN commented 3 months ago

PR Details

Description

When carma exec --gui is called with a command, it correctly sets up nvidia runtime (such as carma exec --gui "rviz" However, if it is just carma exec --gui the script is not setting the nvidia runtime, so nvidia-smi for example won't work.

Related GitHub Issue

NA

Related Jira Key

CAR-6061

Motivation and Context

During porting of rviz to rviz2, I have been using a lot of container with gui enabled. And noticed this inconsistency between two similar calls of same thing.

How Has This Been Tested?

fusion vehicle pc

Types of changes

Checklist:

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud