usdot-jpo-ode / wzdx

The Work Zone Data Exchange (WZDx) Specification aims to make harmonized work zone data provided by infrastructure owners and operators (IOOs) available for third party use, making travel on public roads safer and more efficient through ubiquitous access to data on work zone activity.
Creative Commons Zero v1.0 Universal
89 stars 62 forks source link

Add road_direction property to FieldDeviceCoreDetails #273

Closed j-d-b closed 2 years ago

j-d-b commented 2 years ago

This PR resolves #250 by adding a road_direction property to the FieldDeviceCoreDetails object. Specifically, the following changes were made:

As more enumerated types are shared between feeds, we can consider further organization of the JSON schema files.

sknick-iastate commented 2 years ago

The only minor change I see is that the FieldDeviceCoreDetails needs to be added to the used by section of the Direction enumerations. Everything else looks good.

eli104 commented 2 years ago

I apologize if this comment is late to the discussion, and/or if it's already been discussed elsewhere: I notice on the Direction Enumeration that the values are based on TMDD link-alignment Enumeration... which itself also notes "inner-loop" and "outer-loop" to help refine the direction of the road flow.

Are these additional attrobutes something that have, or should be, considered? Perhaps under Direction or perhaps in the RoadEventCoreDetails (further enhancing the requirements of the "road_name")?

Reasons:

Again my apologies if this has already been discussed (or if the discussion needs to move somewhere else... so be it).

j-d-b commented 2 years ago

@eli104 see #324—the discussion can be continued there.

j-d-b commented 2 years ago

The only minor change I see is that the FieldDeviceCoreDetails needs to be added to the used by section of the Direction enumerations.

@sknick-iastate Thank you, fixed and pushed.