Closed j-d-b closed 2 years ago
The only minor change I see is that the FieldDeviceCoreDetails needs to be added to the used by section of the Direction enumerations. Everything else looks good.
I apologize if this comment is late to the discussion, and/or if it's already been discussed elsewhere: I notice on the Direction Enumeration that the values are based on TMDD link-alignment Enumeration... which itself also notes "inner-loop" and "outer-loop" to help refine the direction of the road flow.
Are these additional attrobutes something that have, or should be, considered? Perhaps under Direction or perhaps in the RoadEventCoreDetails (further enhancing the requirements of the "road_name")?
Reasons:
Again my apologies if this has already been discussed (or if the discussion needs to move somewhere else... so be it).
@eli104 see #324—the discussion can be continued there.
The only minor change I see is that the FieldDeviceCoreDetails needs to be added to the used by section of the Direction enumerations.
@sknick-iastate Thank you, fixed and pushed.
This PR resolves #250 by adding a
road_direction
property to the FieldDeviceCoreDetails object. Specifically, the following changes were made:road_direction
property to the FieldDeviceCoreDetails object.As more enumerated types are shared between feeds, we can consider further organization of the JSON schema files.