usecannon / cannon

Manage EVM protocol deployments. Inspired by Docker, Terraform, and npm.
https://usecannon.com
GNU General Public License v3.0
103 stars 20 forks source link

feat(website): CAN-474 link to navigate to a package. #1357

Closed nicosampler closed 2 weeks ago

nicosampler commented 3 weeks ago

navigate to a package using a link.

Closes #CAN-474

changeset-bot[bot] commented 3 weeks ago

⚠️ No Changeset found

Latest commit: 20f6f91d21015595e2203933d528b64d27620d50

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

nicosampler commented 2 weeks ago

Need background as to why we are doing this.

Also I want to confirm, this is still static-site compatible, right?

this change was requested by @noahlitvin and Syntetix. here is the ticket: https://linear.app/usecannon/issue/CAN-474/enable-ability-to-ctrlclick-to-open-items-in-new-tabs

Yes, it is nothing different from any of the links we use in other places. Adding this weird link wrapping each td is a workaround @noahlitvin proposed to make the row clickable as it was before.