usecannon / cannon

Manage EVM protocol deployments. Inspired by Docker, Terraform, and npm.
https://usecannon.com
GNU General Public License v3.0
103 stars 20 forks source link

feat(cli): Support `--anvil.*` flags #1358

Closed saeta-eth closed 1 week ago

saeta-eth commented 3 weeks ago

This PR makes a clearer distinction between Cannon and Anvil flags by prefixing Anvil flags with --anvil.*, improving clarity and making their origin explicit. It also includes the upgrade to the latest version of Commander.

Closes https://linear.app/usecannon/issue/CAN-508/add-foundry-params-to-all-cannon-commands-with-forge-and-anvil

changeset-bot[bot] commented 3 weeks ago

⚠️ No Changeset found

Latest commit: de2af0498dc86baab316cc255c75b74ba91c2fb3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

saeta-eth commented 2 weeks ago

would be really cool if we could progmatically just pass any arguments based on if they start with --anvil. prefix rather than having to code them here (that way if they add/change arguments in the future, it always works with user's setup)

I get what you’re saying and I tend to agree but I found two reasons to keep them in the code: 1- they’re used in the docs on the website, 2- if someone mistypes a flag, commander suggests the right one