search

uselagoon / lagoon-charts

A collection of Helm charts for Lagoon and associated services.
Apache License 2.0
11 stars 10 forks source link

lagoon-core default imagePullPolicy is Always #675

Open shreddedbacon opened 2 months ago

shreddedbacon commented 2 months ago

The default imagePullPolicy is Always for the lagoon-core chart.

Would it make sense to use IfNotPresent for releases, and leave Always for testing/local-dev only?

I want to use IfNotPresent so that restarting containers is quicker in a deployed production Lagoon, currently I need to modify all the services individually, as there isn't a way to set the policy override globally.

For example, there is an ability to provide a .imageTag that can be applied to most images that use the lagoon-core version. It would be nice to be able to have a .pullPolicy value that could be used for changing the imagePullPolicy on these same images.

image: "{{ .Values.apiRedis.image.repository }}:{{ coalesce .Values.apiRedis.image.tag .Values.imageTag .Chart.AppVersion }}"
imagePullPolicy: {{ .Values.apiRedis.image.pullPolicy }}
tobybellwood commented 2 months ago

I think this makes sense to implement - we don't* reuse release tags