uselotus / lotus

Open Source Pricing & Packaging Infrastructure
https://www.uselotus.io
MIT License
1.73k stars 126 forks source link

add e2e event tracking test #745

Closed diego-escobedo closed 1 year ago

diego-escobedo commented 1 year ago

Resolves LOT-691

linear[bot] commented 1 year ago
LOT-691 Bug - Test(s) for tracking events

\### Summary We have been bit so many times because we aren't testing our event ingestion. We tried to do this on the frontend but there are complications there regarding which events show up when and if there is a delay. This should definitely be a backend test and one of the most important. Testing if an event gets through ingestion then gets to guidance and makes it into the database correctly.

gitguardian[bot] commented 1 year ago

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [6108675](https://dashboard.gitguardian.com/incidents/6108675?occurrence=88804440) | Generic High Entropy Secret | 58680fd1ed16c05cca57bbd127bd7d89e5fd8236 | .github/workflows/events-e2e.yml | [View secret](https://github.com/uselotus/lotus/commit/58680fd1ed16c05cca57bbd127bd7d89e5fd8236#diff-39736ffe18292c4900e679698bf500dcd3766c76dab28555e2457fa4d1c57fa8R35) | | [6108675](https://dashboard.gitguardian.com/incidents/6108675?occurrence=88807160) | Generic High Entropy Secret | d056d19aba220d246b1ec6b33da45807d4156e91 | .github/workflows/events-e2e.yml | [View secret](https://github.com/uselotus/lotus/commit/d056d19aba220d246b1ec6b33da45807d4156e91#diff-39736ffe18292c4900e679698bf500dcd3766c76dab28555e2457fa4d1c57fa8L35) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/detectors/generics/generic_high_entropy_secret#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!