userofbricks / Expanded-Combat

https://www.curseforge.com/minecraft/mc-mods/expanded-combat
Other
2 stars 3 forks source link

NeoForge build breaks with Accessories' Curios API #78

Open NovaViper opened 1 week ago

NovaViper commented 1 week ago

Hey, I just installed the NeoForge build of Expanded Combat along with Accessories (with its Curios API layer) and the game immediately crashes with this error:

[23:29:47] [modloading-sync-worker/FATAL] [mixin/]: Mixin apply for mod expanded_combat failed expanded_combat.mixins.json:CuriosMenuMixin from mod expanded_combat -> top.theillusivec4.curios.common.inventory.container.CuriosContainer: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException Critical injection failure: @Inject annotation on inventoryMenu could not find any targets matching 'setPage' in top/theillusivec4/curios/common/inventory/container/CuriosContainer. No refMap loaded. [INJECT_PREPARE Applicator Phase -> expanded_combat.mixins.json:CuriosMenuMixin from mod expanded_combat -> Prepare Injections -> handler$zzc000$expanded_combat$inventoryMenu(ILorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;)V -> Parse ->  -> Validate Targets]
org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: Critical injection failure: @Inject annotation on inventoryMenu could not find any targets matching 'setPage' in top/theillusivec4/curios/common/inventory/container/CuriosContainer. No refMap loaded. [INJECT_PREPARE Applicator Phase -> expanded_combat.mixins.json:CuriosMenuMixin from mod expanded_combat -> Prepare Injections -> handler$zzc000$expanded_combat$inventoryMenu(ILorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;)V -> Parse ->  -> Validate Targets]

I'm running Minecraft 1.21.1 with NeoForge 21.1.74/21.1.77 Logs: https://mclo.gs/vJvoDiA

userofbricks commented 1 week ago

The mod will break with Accessories as my mod overwrites some things in the curios inventory and the only mod out there that has the curios inventory for 1.21.x is Curios API: Continued. So for now I am considering this a non-issue until I have the time to add base compatibility with Accessories.

EDIT: Adorned might also be compatible but don't get your hopes up.

userofbricks commented 1 week ago

leaving this open for others to see