usi-verification-and-security / opensmt

The opensmt solver

Other

78 stars 18 forks source link

consolidate `bin` directories and executables #671

Open Tomaqa opened 9 months ago

Tomaqa commented 9 months ago

[x] get rid of ./bin/ where confusingly a source code is present
[ ] either place the executable ./build/opensmt into ./build/bin or get rid of currently empty ./build/bin

blishko commented 9 months ago

674 solves the first part, it removes `bin` from the root directory.

Regarding the second part, it looks like cmake is creating bin directory in the build directory already at configure phase, i.e, when running cmake -B, before the actual build system (like make) is run. Since we do not put anything there during build, it ends up empty. I have not managed to find out why cmake creates this directory or how to prevent it from doing it.

Tomaqa commented 9 months ago

I also did not find this out, I only found out how to put the executable into this bin directory, by setting RUNTIME_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/bin" (note the */bin) in src/bin/CMakeLists.txt.

From this I assume that ${CMAKE_BINARY_DIR} is set to <build>, which confuses me even more why the bin directory is being created..

usi-verification-and-security / opensmt

consolidate `bin` directories and executables #671

674 solves the first part, it removes bin from the root directory.

674 solves the first part, it removes `bin` from the root directory.