search

usmanatron / amBXPeripheralController

Server application (with a number of assisting clients) to control amBX gaming peripherals
Other
2 stars 4 forks source link

Minor improvements to tests #2

Closed MatthewRichards closed 10 years ago

MatthewRichards commented 10 years ago

I hope you can review this diff in a nicer way than the GitHub default, which seems distinctly inferior to Crucible. I don't seem to be able to add comments to individual changes, but hopefully most of them are obvious - come and grab me for an explanation of any that seem odd (whether or not you decide to actually merge them in).

usmanatron commented 10 years ago

Thanks Matthew, I'll have a look and let you know. May grab a diff and do it offline though, as I agree its a bit unclear through GitHub!

EDIT: btw, I should have probably told you that a couple of days ago I merged that branch back into master (and have since re-architected all of the things... again!). Shouldn't be a problem though I suspect...

usmanatron commented 10 years ago

Hi Matthew. I've finally managed to have a look at this in a nicer way - it turns out most of your changes are whitespace ones and you can ignore whitespace in diffs by adding ?w=1 to the Url - makes it much more manageable!

As for the changes, they all look pretty good (especially the one checking the built in scenes - a lot cleaner!). As this branch is now very old, I'm going to accept \ merge this request and then merge back into master.

Thanks!