search

usnistgov / blcc

BLCC conducts economic analyses by evaluating the relative cost effectiveness of alternative buildings and building-related systems or components.
1 stars 0 forks source link

Results Calcs - Residual Value not being included #89

Open jkneifel opened 1 month ago

jkneifel commented 1 month ago

Use OMB Non-Energy example: I included a residual value for Alternative = Buy; Capital Cost = Buying, but no residual value is appearing in the results. Either its not being included or not be calculated correctly. Maybe the calculation is creating a zero value (decimal place issue?).

jkneifel commented 4 weeks ago

Looking at the E3 output file. The Buy Alternative shows non-discounted values as... "totalTagCashflowNonDiscounted": [5000000.0, 200000.0, 200000.0, 200000.0, 200000.0, 200000.0, 200000.0, 200000.0, 200000.0, 200000.0, 200000.0, 200000.0, 200000.0, 200000.0, 200000.0, 200000.0], The last year should also include a -2,300,000 value for the residual value of the Buying capital cost. I included a value for residual value in the object (50%). It's not showing up in the residual value tag (which is where it should be) or the initial investment tag, (which I could have seen as an easy mistake to make).

dw13813 commented 4 weeks ago

Just did a quick check and this is likely an E3 issue. For both non-recurring and recurring costs the following is happening:

residualValue = true and residualValueOnly = true - discounted values are appearing correctly. Non discounted values and quantity are showing up as though the costs are being used without a residual value.

residualValue = true and residualValueOnly = false - all costs are appearing as though they are being used without a residual value calculation.

I'll look more into the code later today and see if I can spare Luke some time switching from BLCC to E3.

jkneifel commented 4 weeks ago

David, We are designing BLCC to create a separate object for residual value because it is not assuming the linear depreciation approach that we have built into that residualValue option. The user provides a factor that determines the remaining value as a fraction of the original cost and a potential cost adjustment factor. So I do not think that is causing an issue with BLCC. But if you found an error in E3, we should get that fixed when we have a chance. Josh

From: David Webb @.> Sent: Thursday, October 31, 2024 12:55 PM To: usnistgov/blcc @.> Cc: Kneifel, Joshua D. (Fed) @.>; Author @.> Subject: Re: [usnistgov/blcc] Results Calcs - Residual Value not being included (Issue #89)

Just did a quick check and this is likely an E3 issue. For both non-recurring and recurring costs the following is happening:

residualValue = true and residualValueOnly = true - discounted values are appearing correctly. Non discounted values and quantity are showing up as though the costs are being used without a residual value.

residualValue = true and residualValueOnly = false - all costs are appearing as though they are being used without a residual value calculation.

I'll look more into the code later today and see if I can spare Luke some time switching from BLCC to E3.

— Reply to this email directly, view it on GitHubhttps://github.com/usnistgov/blcc/issues/89#issuecomment-2450367556, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGHOLOEGU7FEIBL46JX2R7TZ6JOHHAVCNFSM6AAAAABQRKDZJ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJQGM3DONJVGY. You are receiving this because you authored the thread.Message ID: @.***>