Closed reid-a closed 4 years ago
Merging #103 into master will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #103 +/- ##
=======================================
Coverage 92.16% 92.16%
=======================================
Files 46 46
Lines 5563 5563
=======================================
Hits 5127 5127
Misses 436 436
Impacted Files | Coverage Δ | |
---|---|---|
jarvis/analysis/interface/zur.py | 98.15% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7f2cb18...ef3568c. Read the comment docs.
Hi @reid-a thanks for submitting the pull-request. Please run flake8, pycodestyle and pydocstyle with zur.py and see if it gives some error. Right now, the tests are failing because of the following reasons:
jarvis/analysis/interface/zur.py:448:1: E302 expected 2 blank lines, found 0 jarvis/analysis/interface/zur.py:451:1: E305 expected 2 blank lines after class or function definition, found 1
Also, you may have to add a docstring line to the modules, which you can find in an older version e.g.: https://github.com/usnistgov/jarvis/blob/v2020.7.4/jarvis/analysis/interface/zur.py#L373
Added stub functions to the zur.py file. These functions are imported but not used by the still-deployed version of the heterostructures app. Re-adding them here localizes the changes to a single repo. The long-term solution will remove both these stubs and the imports in the other repo, but this is a good near-term solution.