search

uswds / uswds-sandbox

11ty site for rapid web prototyping and testing new work with USWDS
19 stars 14 forks source link

Jekyll runtime error when attempting to serve locally #8

Closed carlvlewis closed 6 years ago

carlvlewis commented 6 years ago

Issue

Upon running bundle exec jekyll serve, the process fails after apparently encountering a conversion error in /node_modules/uswds/dist/scss.

Error message

Conversion error: Jekyll::Converters::Scss encountered an error while converting 'assets/css/main.scss': $string: #0000ff is not a string for 'quote' on line 106

Efforts to debug

Unable to pinpoint the location of quote via text search or browsing. Not sure where this error in the code is presenting itself

Reproducibility

Have attempted to deploy with Siteleaf and Cloudcannon; both efforts fail, citing the same issue in the error logs.

maya commented 6 years ago

Hi, thanks for opening this issue. Adding a note that this error is also appearing on our build: https://federalist.18f.gov/sites/446/builds/46130/logs

thisisdano commented 6 years ago

So I will look into this — but going forward with 2.0 we can't recommend using Jekyll's built-in sass transpiling, since USWDS 2.0 Sass will require both autoprefixing and media query packing to work properly — the latter of which is (as far as I know) not possible in the Jekyll Sass ecosystem.

Everything compiles properly using gulp-sass, but it will be worth tracking down this error as it likely points to something that we should fix regardless.

thisisdano commented 6 years ago

(And Jekyll Sass is slow and, as we see with this error, has poor error reporting...)

carlvlewis commented 6 years ago

Not Jekyll Sass again! That dependency is the bane of my existence lately...

On Jul 18, 2018 at 1:02 PM, Dan O. Williams notifications@github.com wrote:

(And Jekyll Sass is slow and, as we see with this error, has poor error reporting...)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/uswds/uswds-sandbox/issues/8#issuecomment-406003899, or mute the thread https://github.com/notifications/unsubscribe-auth/ABnnIWqKu3uxtrTGA4_T6hfPrscLc10Cks5uH2o0gaJpZM4VUDrQ .

thisisdano commented 6 years ago

This should be fixed by https://github.com/uswds/uswds/pull/2598

maya commented 6 years ago

Since #2598 is merged, is this good to close?

thisisdano commented 6 years ago

I think we should just confirm that it's fixed, then close.

maya commented 6 years ago

Confirming that #7 is building properly now 🎉