search

utkarshkukreti / draco

Draco is a Rust library for building client side web applications with Web Assembly.
Apache License 2.0
302 stars 18 forks source link

Replaced yanked int_hash with rustc_hash #15

Closed BurNiinTRee closed 5 years ago

BurNiinTRee commented 5 years ago

Trying to use the current library in an app yields the currnt error on cargo build --target=wasm32-unknown-unknown:

    Updating crates.io index
error: no matching package named `int_hash` found
location searched: registry `https://github.com/rust-lang/crates.io-index`
required by package `draco v0.1.1`
    ... which is depended on by `draco-test v0.1.0 (/home/lars/tmp/draco-test)`

The same happens when using the git version of draco. Building a separate checkout of draco strangely works though.

This pull request replaces all uses of int_hash's IntHashMap with rustc-hash's FxHashMap as is suggested by the maintainer of int_hash.

theduke commented 5 years ago

Haha @BurNiinTRee I just did the same thing ( #17 )

BurNiinTRee commented 5 years ago

Haha I like yours better, I didn't bother checking where it was actually used and just aliased the import, yours is cleaner.

On 12/10/18 2:40 PM, theduke wrote:

Haha @BurNiinTRee https://github.com/BurNiinTRee I just did the same thing ( #17 https://github.com/utkarshkukreti/draco/pull/17 )

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/utkarshkukreti/draco/pull/15#issuecomment-445818382, or mute the thread https://github.com/notifications/unsubscribe-auth/AHmW7dsvAPUa8T455kOecYqvPcaHSWCVks5u3mRBgaJpZM4ZLT-_.