Optional generation of separate swagger file

utrack / clay

Proto-first minimal server platform for gRPС+REST+Swagger APIs

MIT License

289 stars 39 forks source link

Optional generation of separate swagger file #90

Closed bullgare closed 4 years ago

bullgare commented 4 years ago

This file can be used for some integrations like Apiary. It is optional and not turned on by default. Does not break backward compatibility.

utrack commented 4 years ago

LGTM, thanks!

bullgare commented 4 years ago

Thank you!

bullgare commented 4 years ago

@utrack do you have plans to make a release in near future?

utrack commented 4 years ago

done, v2.4.9

bullgare commented 4 years ago

Oh, cool! Thank you.

On Wed, 17 Jun 2020 at 08:59, Nick Koptelov notifications@github.com wrote:

done, v2.4.9

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/utrack/clay/pull/90#issuecomment-645190713, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAG74YYC7HGHQ5LZ6QMZ3L3RXBSWNANCNFSM4N5CQRSQ .

               best, Dmitry

bullgare commented 4 years ago

filepath.Join(g.options.SwaggerPath, fmt.Sprintf("%s.json", base))

Well, yes, you are right, @NOMORECOFFEE . But we are not about performance here. If we were discussing not merged PR, I'd fix it, but it's been released for about 3 months now. So if you want it, feel free to create another PR to fix the ordering here.