s2pctl crashes with segmentation fault in interactive mode when "enter" key is pressed without any other input

[fdanapfel]

When creating a new ticket please provide information on your environment.

• The Pi type: Zero 2 W

• The Pi OS version (output of 'lsb_release -a'): Distributor ID: Debian Description: Debian GNU/Linux 12 (bookworm) Release: 12 Codename: bookworm

• The SCSI2Pi release or git revision: scsi2pi_1.2_devel_50d3589_arm64-1.deb

• The computer/sampler connected to the RaSCSI/PiSCSI board: N/A

Describe the issue

When running s2pctl in interactive mode and just pressing enter without entering anything else it crashes with a "Segmentation fault":

$ /opt/scsi2pi/bin/s2pctl 
SCSI Target Emulator and SCSI Tools SCSI2Pi (Server Controller Tool)
Version 1.2-devel
Copyright (C) 2016-2020 GIMONS
Copyright (C) 2020-2023 Contributors to the PiSCSI project
Copyright (C) 2021-2024 Uwe Seimet
Entering interactive mode, Ctrl-D or "exit" to quit
s2pctl>
Segmentation fault

When entering commands it works without issues:

$ /opt/scsi2pi/bin/s2pctl 
SCSI Target Emulator and SCSI Tools SCSI2Pi (Server Controller Tool)
Version 1.2-devel
Copyright (C) 2016-2020 GIMONS
Copyright (C) 2020-2023 Contributors to the PiSCSI project
Copyright (C) 2021-2024 Uwe Seimet
Entering interactive mode, Ctrl-D or "exit" to quit
s2pctl>server-version
Device server version: SCSI2Pi 1.2-devel
s2pctl>

[uweseimet]

@fdanapfel Indeed ;-). For the sake of simplicity I will fix that while working on https://github.com/uweseimet/scsi2pi/issues/37.

[uweseimet]

@fdanapfel The new issue_37 branch should fix this issue. Can you please test? I case you can't, e.g. because you only install binary packages, it's fine, of course. There is still more time for testing, e.g. with an upcoming binary package.

[fdanapfel]

@uweseimet I prefer to use the binary packages, and since this is not a major issue I'm happy to wait until the fix is included in a binary package to test if the issue is fixed.

[uweseimet]

@fdanapfel Development builds with this issue fixed are now available for download.

[fdanapfel]

@uweseimet Thanks, I can confirm that with scsi2pi_1.2_devel_a1a8ada_bookworm_arm64-1.deb the issue no longer occurs:

$ sudo apt install ./scsi2pi_1.2_devel_a1a8ada_bookworm_arm64-1.deb
...
/opt/scsi2pi/bin $ ./s2pctl 
SCSI Target Emulator and SCSI Tools SCSI2Pi (Server Controller Tool)
Version 1.2-devel
Copyright (C) 2016-2020 GIMONS
Copyright (C) 2020-2023 Contributors to the PiSCSI project
Copyright (C) 2021-2024 Uwe Seimet
Entering interactive mode, Ctrl-D or "exit" to quit
s2pctl>
s2pctl>
s2pctl>
s2pctl>server-version
Device server version: SCSI2Pi 1.2-devel
s2pctl>