search

uwolfer / gerrit-intellij-plugin

Gerrit Code Review Tool Integration for the IntelliJ Platform
Apache License 2.0
495 stars 103 forks source link

IDE not showing comments made using the browser #463

Closed ssadoun closed 1 year ago

ssadoun commented 2 years ago

Hello,

First of all, I wanted to thank you for the plugin. It's really helpful!

My issue is that the PyCharm IDE does not show any comments made using the browser. I'll note that a lot of other things are visible. For example, the ACS, ACM, CR, RfP, RfR, and V flags change accordingly. Now I might be missing something here, but it seems like the plugin doesn't pull the comments made using the browser GUI. However, If I open the commit file diff and try to add a new comment, I do see it 🤔

Gerrit v3.5.0.1 PyCharm v2022.1.3 (Community Edition) Gerrit Plugin v1.2.6-203

leoluk commented 2 years ago

Are the missing comments drafts or submitted?

ssadoun commented 2 years ago

Both are not visible.

uwolfer commented 2 years ago

Which diff viewer are you using in PyCharm? Probably you could switch to the old one (side by side), and check if comments show up in that case.

ssadoun commented 2 years ago

Which diff viewer are you using in PyCharm? Probably you could switch to the old one (side by side), and check if comments show up in that case.

I'm using the default diff viewer Pycharm has

uwolfer commented 2 years ago

@ssadoun Could you please post a screenshot of the diff viewer?

ssadoun commented 2 years ago

PyCharm_Diff_Viewer

@uwolfer There is a comment next to line #62 in Gerrit web UI, but it is missing here...

ssadoun commented 1 year ago

@uwolfer ?

uwolfer commented 1 year ago

@ssadoun Sorry for the late response. This sounds really odd, I cannot see the issue. Can you see comments created by others? What happens if you add a comment in IntelliJ, and submit it? Does it still appear after you close the diff viewer and open it again (to make sure, you probably even could restart IntelliJ).

ssadoun commented 1 year ago

@uwolfer I cannot see comments created by others, nor can I add a comment by myself. That is the reason I created this issue in the first place.

I'm using PyCharm, not IntelliJ. Please see the image attached.

uwolfer commented 1 year ago

I'm using PyCharm, not IntelliJ. Please see the image attached.

Yes, I have read that. PyCharm is also based on the IntelliJ platform. For that reason, you can also apply my sentence to PyCharm:

What happens if you add a comment in PyCharm, and submit it? Does it still appear after you close the diff viewer and open it again (to make sure, you probably even could restart PyCharm).

ssadoun commented 1 year ago

@uwolfer I think I understand the problem now. No comments were shown when I used "Repository Diff", but when I used "Open Diff" via the Gerrit plugin, they could be viewed, replied to, and marked as complete.