search

uxebu / bonsai

BonsaiJS is a graphics library and renderer
http://bonsaijs.org
Other
1.96k stars 189 forks source link

Text#attr[textOrigin] #188

Closed basecode closed 11 years ago

basecode commented 11 years ago

This pull request fixes #166 and "silently" adds support for three different textOrigins. Namely "top", "center" and "bottom".

basecode commented 11 years ago

The reason why I propose "textOrigin" being a "silent" or non-public addition is because we're probably changing the behaviour of Text in the future due to #84. IMO making "textOrigin" public would conflict with the idea of exposing a "verticalAlign" API. Could be that the Text API ends up being kind of a TextBox API.

davidaurelio commented 11 years ago

Thanks