Pointer events cleanup and alignment

uxebu / bonsai

BonsaiJS is a graphics library and renderer

http://bonsaijs.org

Other

1.96k stars 189 forks source link

Pointer events cleanup and alignment #195

Closed davidaurelio closed 11 years ago

davidaurelio commented 11 years ago

Cleans up event handling in the svg renderer.
adds “deltaX/Y” and “diffX/Y” to regular “pointermove” events as well (not only drags) when triggered by mouse events.
adds “deltaX/Y” to “pointermove” and “drag” events when triggered by touches
does not send unnecessary drag events to the runner.
Stops memory leaking from touch events.

basecode commented 11 years ago

Thanks, looks good. What about tests?

iamdustan commented 11 years ago

I can’t tell by glancing through this, but does it or would it make sense to include the diffX/diffY from the start coordinate for drag events rather than (or in addition to) the last event emission?

That way things like https://github.com/uxebu/bonsai-demos/blob/gh-pages/demos/draggable-shapes/index.html#L49 can be handled by bonsai and userland doesn’t need to keep track of that state?

davidaurelio commented 11 years ago

Yes, absolutely. I’m already working on it in the next branch.

diffX/Y will be offsets from the start of the drag
deltaX/Y will be offsets relative to the last event (also fired for mousemove)

iamdustan commented 11 years ago

Awesome. :thumbsup:

davidaurelio commented 11 years ago

Closed in favor of #201