search

uxsolutions / bootstrap-datepicker

A datepicker for twitter bootstrap (@twbs)
Apache License 2.0
12.66k stars 6.07k forks source link

bootstrap 4 support #1670

Open acrobat opened 8 years ago

acrobat commented 8 years ago

Bs4 is still in early alpha but when it reaches beta (no api changes after beta) we should take a look into adding a bs4 stylesheet and possibly deprecate bs2 support

hebbet commented 8 years ago

possibly deprecating bs2 support

would drop support for bs2 with the first version supporting bs4

acrobat commented 8 years ago

Yes you are right @hebbet, bs2 is not supported by the twbs team so we should drop it too when moving to bs4

EugenMayer commented 8 years ago

Is there any progress on this side at the moment? We are using bootstrap4-alpha3 pretty heavily already and i would suggest it could make sense migrating this also? We have been using bootstrap-datepicker with bootstrap2 and would love continuing to do so.

What are the expected working-areas to adjust the datebicker? are those mostly theme / css related things?

acrobat commented 8 years ago

I haven't looked into detail on what should/must change, but my first idea is that we would need to switch some classes and provide a bs4 stylesheet

EugenMayer commented 8 years ago

Well if you guys could guide me a little bit, we could try to do some first attempts here to see, how "low hanging fruits" this topic might be and what concrete issues would arise. What do you think?

acrobat commented 8 years ago

@EugenMayer all help is welcome! Maybe you could just load up a bs3 datepicker in the new bs4 style and see what styles are wrong and start making a list of classes/styles (in a separate issue) we should change. That way we have already an idea on how much work this will be

After that we can start on a plan what steps we should take (the introduction of themes is one of those)

EugenMayer commented 8 years ago

Perfect, will do that and report back. We will try to see what we can fix and show off those things using pull requests to see, how things work out

acrobat commented 8 years ago

That's great @EugenMayer, thanks!

Azaret commented 7 years ago

This will be done when the backends stuff is done. Not that in my hand I won't create a backend that support BS4, tho I'll create on for BS2, mainly because I do still use BS2 on some projects.

johan-bjareholt commented 7 years ago

Since others are referencing this issue mentioning that it works but isn't officially supported and bootstrap4 has been stable for quite some time, when do you expect to make it officially support bootstrap4?

EugenMayer commented 7 years ago

bootstrap is no close to stable - still :) lets talk about it 2020, when a first rc1 probably gonna hit the public.

hint to myself: https://github.com/twbs/bootstrap/milestone/41 beta1 probably even about to happen! 4 issues left, i am a bit suprised

hint2: oh.. https://github.com/twbs/bootstrap/issues/20631 somebody finally opened their eyes, wonderful!

alvipeo commented 7 years ago

I gave up on bootstrap completely about 6 months ago and happy! Use semantic-ui or material.

johan-bjareholt commented 7 years ago

Wow, I didn't know it was this bad. I was using bootstrap-vue which is the only vue2 plugin which uses bootstrap and it used bootstrap4 so i assumed it was stable.

ndabAP commented 7 years ago

@johan-bjareholt, I'm in the exact same situation. Using bootstrap-vue and looking for a Bootstrap 4 datetimepicker.

ieugen commented 7 years ago

Bootstrap 4 has just gone beta today. Happy coding!

gustavostuff commented 6 years ago

Hey guys, how stable is BS4 support right now? (for the beta version)

acrobat commented 6 years ago

At this point we should be able to start work on bs4 support ideally with some sort of theme support so we can easily support bs3 and bs4 (and even other themes if necessary).

I don't have the time (and js knowledge) to start work on this feature. Therefor I've opened #2252 to request some extra helper from active JS developers. This way we can, hopefully, get more feature implemented and bugs fixed! So any idea's and development help are welcome!

NSExceptional commented 5 years ago

Any progress?

ttskch commented 4 years ago

maybe same as #1574

aasutossh commented 3 years ago

Let's specify on the readme that BS4 isn't supported so that people like me don't have to beat their head. It says it needs BS2.0.4+ on the RTD, I assumed that it would support BS4.