it would be nice if the discovery have more options

colttt commented 6 years ago

Hello,

at first, great job ;) BUT, I've a JBOD with al lot disks (42) and i use partlabel to identify this with a schema, for example j1d01-ssd that means in jbod1 disk 01 and its an ssd, so it would be nice if i see that in zabbix instead of sdam, also some users with a lot of disks are using by-uuid and get pci-0000:03:00.0-sas-exp0x50030480091018ff-phy3-lun-0

best regards

v-zhuravlev commented 6 years ago

HI, thanks

can you give the output of discovery script?
and some sample output of smartctl?
and what do you want to replace with what again.

colttt commented 6 years ago

Hi,

can you give the output of discovery script?

perl smartctl-disks-discovery.pl 
{
    "data":[

            {
                    "{#DISKNAME}":"/dev/sda -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sdb -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sdc -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sdd -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sde -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sdf -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sdg -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sdh -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sdi -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sdj -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sdk -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sdl -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sdm -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sdn -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sdo -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sdp -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sdq -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sdr -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sds -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sdt -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sdu -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sdv -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sdw -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sdx -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sdy -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sdz -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sdaa -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sdab -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sdac -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sdad -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sdae -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sdaf -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sdag -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sdah -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sdai -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sdaj -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sdak -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sdal -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sdam -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sdan -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sdao -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sdap -d scsi",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sdaq -d sat",
                    "{#SMART_ENABLED}":"1"
            },
            {
                    "{#DISKNAME}":"/dev/sdar -d sat",
                    "{#SMART_ENABLED}":"1"
            }
    ]
}

and some sample output of smartctl?


smartctl --scan-open
/dev/sda -d scsi # /dev/sda, SCSI device
/dev/sdb -d scsi # /dev/sdb, SCSI device
/dev/sdc -d scsi # /dev/sdc, SCSI device
/dev/sdd -d scsi # /dev/sdd, SCSI device
/dev/sde -d scsi # /dev/sde, SCSI device
/dev/sdf -d scsi # /dev/sdf, SCSI device
/dev/sdg -d scsi # /dev/sdg, SCSI device
/dev/sdh -d scsi # /dev/sdh, SCSI device
/dev/sdi -d scsi # /dev/sdi, SCSI device
/dev/sdj -d scsi # /dev/sdj, SCSI device
/dev/sdk -d scsi # /dev/sdk, SCSI device
/dev/sdl -d scsi # /dev/sdl, SCSI device
/dev/sdm -d scsi # /dev/sdm, SCSI device
/dev/sdn -d scsi # /dev/sdn, SCSI device
/dev/sdo -d scsi # /dev/sdo, SCSI device
/dev/sdp -d scsi # /dev/sdp, SCSI device
/dev/sdq -d scsi # /dev/sdq, SCSI device
/dev/sdr -d scsi # /dev/sdr, SCSI device
/dev/sds -d scsi # /dev/sds, SCSI device
/dev/sdt -d scsi # /dev/sdt, SCSI device
/dev/sdu -d scsi # /dev/sdu, SCSI device
/dev/sdv -d scsi # /dev/sdv, SCSI device
/dev/sdw -d scsi # /dev/sdw, SCSI device
/dev/sdx -d scsi # /dev/sdx, SCSI device
/dev/sdy -d scsi # /dev/sdy, SCSI device
/dev/sdz -d scsi # /dev/sdz, SCSI device
/dev/sdaa -d scsi # /dev/sdaa, SCSI device
/dev/sdab -d scsi # /dev/sdab, SCSI device
/dev/sdac -d scsi # /dev/sdac, SCSI device
/dev/sdad -d scsi # /dev/sdad, SCSI device
/dev/sdae -d scsi # /dev/sdae, SCSI device
/dev/sdaf -d scsi # /dev/sdaf, SCSI device
/dev/sdag -d scsi # /dev/sdag, SCSI device
/dev/sdah -d scsi # /dev/sdah, SCSI device
/dev/sdai -d scsi # /dev/sdai, SCSI device
/dev/sdaj -d scsi # /dev/sdaj, SCSI device
/dev/sdak -d scsi # /dev/sdak, SCSI device
/dev/sdal -d scsi # /dev/sdal, SCSI device
/dev/sdam -d scsi # /dev/sdam, SCSI device
/dev/sdan -d scsi # /dev/sdan, SCSI device
/dev/sdao -d scsi # /dev/sdao, SCSI device
/dev/sdap -d scsi # /dev/sdap, SCSI device
/dev/sdaq -d sat # /dev/sdaq [SAT], ATA device
/dev/sdar -d sat # /dev/sdar [SAT], ATA device

=== START OF READ SMART DATA SECTION === Current Drive Temperature: 27 C Drive Trip Temperature: 70 C

Manufactured in week 30 of year 2017 Specified cycle count over device lifetime: 0 Accumulated start-stop cycles: 0 Specified load-unload count over device lifetime: 0 Accumulated load-unload cycles: 0 defect list format 6 unknown Elements in grown defect list: 0

Vendor (Seagate) cache information Blocks sent to initiator = 38070455894016

- and what do you want to replace with what again.

ls -1 /dev/disk/by-partlabel/ j1d00-ssd j1d01-ssd j1d02-ssd j1d03-hdd j1d04-hdd j1d05-hdd j1d06-hdd j1d07-hdd j1d08-hdd j1d09-hdd j1d10-hdd j1d11-hdd j1d12-hdd j1d13-hdd j1d14-hdd j1d15-hdd j1d16-hdd j1d17-hdd j1d18-hdd j1d19-hdd j1d20-hdd j2d00-ssd j2d01-ssd j2d02-ssd j2d03-hdd j2d04-hdd j2d05-hdd j2d06-hdd j2d07-hdd j2d08-hdd j2d09-hdd j2d10-hdd j2d11-hdd j2d12-hdd j2d13-hdd j2d14-hdd j2d15-hdd j2d16-hdd j2d17-hdd j2d18-hdd j2d19-hdd j2d20-hdd

also be interesting can be something in /dev/disk/by-path/ like

ls -1 /dev/disk/by-path/ pci-0000:00:1f.2-ata-1 pci-0000:00:1f.2-ata-1-part1 pci-0000:00:1f.2-ata-1-part2 pci-0000:00:1f.2-ata-1-part5 pci-0000:00:1f.2-ata-2 pci-0000:00:1f.2-ata-2-part1 pci-0000:00:1f.2-ata-2-part2 pci-0000:00:1f.2-ata-2-part5 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy0-lun-0 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy0-lun-0-part1 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy10-lun-0 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy10-lun-0-part1 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy11-lun-0 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy11-lun-0-part1 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy1-lun-0 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy1-lun-0-part1 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy28-lun-0 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy28-lun-0-part1 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy29-lun-0 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy29-lun-0-part1 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy2-lun-0 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy2-lun-0-part1 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy30-lun-0 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy30-lun-0-part1 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy31-lun-0 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy31-lun-0-part1 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy32-lun-0 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy32-lun-0-part1 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy33-lun-0 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy33-lun-0-part1 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy34-lun-0 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy34-lun-0-part1 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy35-lun-0 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy35-lun-0-part1 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy36-lun-0 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy36-lun-0-part1 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy3-lun-0 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy3-lun-0-part1 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy4-lun-0 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy4-lun-0-part1 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy5-lun-0 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy5-lun-0-part1 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy6-lun-0 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy6-lun-0-part1 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy7-lun-0 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy7-lun-0-part1 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy8-lun-0 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy8-lun-0-part1 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy9-lun-0 pci-0000:01:00.0-sas-exp0x5003048009101aff-phy9-lun-0-part1 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy0-lun-0 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy0-lun-0-part1 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy10-lun-0 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy10-lun-0-part1 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy11-lun-0 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy11-lun-0-part1 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy1-lun-0 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy1-lun-0-part1 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy28-lun-0 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy28-lun-0-part1 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy29-lun-0 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy29-lun-0-part1 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy2-lun-0 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy2-lun-0-part1 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy30-lun-0 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy30-lun-0-part1 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy31-lun-0 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy31-lun-0-part1 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy32-lun-0 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy32-lun-0-part1 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy33-lun-0 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy33-lun-0-part1 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy34-lun-0 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy34-lun-0-part1 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy35-lun-0 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy35-lun-0-part1 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy36-lun-0 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy36-lun-0-part1 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy3-lun-0 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy3-lun-0-part1 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy4-lun-0 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy4-lun-0-part1 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy5-lun-0 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy5-lun-0-part1 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy6-lun-0 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy6-lun-0-part1 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy7-lun-0 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy7-lun-0-part1 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy8-lun-0 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy8-lun-0-part1 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy9-lun-0 pci-0000:03:00.0-sas-exp0x50030480091018ff-phy9-lun-0-part1


thanks in advance

v-zhuravlev commented 6 years ago

not sure how to map those lists to smartctl output at the moment... any ideas?

colttt commented 6 years ago

hmm not really, but this are all symlinks, so maybe you can make a list and compare/map it?

ls -Alog /dev/disk/by-partlabel/
total 0
lrwxrwxrwx 1 11 Nov  2 12:10 j1d00-ssd -> ../../sdaa1
lrwxrwxrwx 1 11 Nov  2 12:10 j1d01-ssd -> ../../sdab1
lrwxrwxrwx 1 11 Nov  2 12:10 j1d02-ssd -> ../../sdad1
lrwxrwxrwx 1 11 Nov  2 12:10 j1d03-hdd -> ../../sdae1
lrwxrwxrwx 1 11 Nov  2 12:10 j1d04-hdd -> ../../sdaf1
[...]

ls -Alog /dev/disk/by-partlabel/ |awk ' /j/ {print $7 "  " $9}'
j1d00-ssd  ../../sdaa1
j1d01-ssd  ../../sdab1
j1d02-ssd  ../../sdad1
j1d03-hdd  ../../sdae1
j1d04-hdd  ../../sdaf1
[...]

colttt commented 6 years ago

its done by #46 the output looks like

                {
                        "{#DISKNAME}":"/dev/sdam -d scsi",
                        "{#DISK_PARTNAME}":"j1d17-hdd",
                        "{#DISK_PATH}":"pci-0000:03:00.0-sas-exp0x50030480091018ff-phy33-lun-0-part1",
                        "{#SMART_ENABLED}":"1"
                },

v-zhuravlev / zbx-smartctl

it would be nice if the discovery have more options #44