v3ss0n / goto

GOTO using Atom's Symbols
MIT License
46 stars 17 forks source link

Indexing hangs Atom #16

Open robingram opened 10 years ago

robingram commented 10 years ago

Indexing completely fails on my codebase which is reasonably large but not huge (about 35MB). Atom hangs completely and the memory use of the process keeps growing. I've had this continue for up to 15 minutes before giving up and killing the process. I do have a very large media folder but I assume it will be ignoring image asset files. The code base is a PHP/Magento installation. Running on Windows, Atom v0.129.0.

Elexy commented 9 years ago

Having the same issue on a moderate size Symfony PHP project, zipped 35 MB. btw, I tried using the CTAGs building and stopped that after 15 minutes and a tags file of 12GB

dMathieuD commented 9 years ago

Same issue with a crash at the end. I have a crash stack trace if needed.

danjuls commented 9 years ago

Same issue here, had to close Atom since it appeared to get stuck

gustavolobo commented 9 years ago

Same here.

mkleehammer commented 9 years ago

I'll look into this, but I am actually switching back to Emacs for a while. I'll be looking for someone to take over my Atom projects. If anyone is interested, let me know. I'll also check on the Atom discussion board.

talcloudshare commented 9 years ago

Same here

acusti commented 9 years ago

@v3ss0n To my mind, this is the biggest issue with the package, but I also think the general problem is largely unsolvable (it takes a long time to go through all the files in the project, parse them using the corresponding grammar, and then iterate through parsed tokens to figure out if they are symbols).

It might help, however, to make the SymbolIndex::processDirectory and SymbolIndex::processFile logic async. This would also mean that we could try to show the symbol list immediately and update it in realtime as the index builds itself.

v3ss0n commented 9 years ago

I just reproudced it , it makes my atom crashed too and had to disable. making it async or worker proecess will help a lot. We need to test a bit .

kazkovsky commented 9 years ago

same here

jarhart commented 9 years ago

This is happening to me on two code bases that it used to work fine with, one of which I haven't touched.

rolfrussell commented 9 years ago

same here

despairblue commented 8 years ago

Removing this line could also help. Logging that much does affect performance (I tried to save the whole log for an elm project, it was over 10mb, also atom crashed while saving it).

acusti commented 7 years ago

This is by no means fixed, but it is improved as of 1.8.0. Also, I can recommend a few techniques to help: