v923z / micropython-builder

Ready-to-run firmware files with micropython and ulab
MIT License
29 stars 13 forks source link

support ESP32-UNICORE variant #20

Closed mzhboy closed 1 year ago

mzhboy commented 1 year ago

This variant is supported on micropython esp32 generic page can you please include this variant in micropython builder

v923z commented 1 year ago

I would be happy to add this, but it's not clear to me, what the board's name is, and I don't find it in the micropython github workflow. https://github.com/micropython/micropython/blob/516385c4ccbb1f7fa9dbd37a44ed8ae33dcf1942/ports/esp32/boards/ESP32_GENERIC/board.md mentions that UNICORE is the board's name, but with that the script actually fails.

mzhboy commented 1 year ago

It's a generic esp32-solo-01 module from espressif

v923z commented 1 year ago

That doesn't compile: https://github.com/v923z/micropython-builder/actions/runs/6522719443/job/17712584072?pr=21. What I don't know is which board one has to specify for the build.

In the PR https://github.com/v923z/micropython-builder/pull/21, you can see that I've tried quite a few variants, and all failed.

mzhboy commented 1 year ago

Hi, after looking at [micropython building manual of esp32]($ make BOARD=ESP32_GENERIC BOARD_VARIANT=OTA). I think the correct command should be $ make BOARD=ESP32_GENERIC BOARD_VARIANT=UNICORE board variant can be found at esp32 board.json

v923z commented 1 year ago

Merged into master, closing now.